CROSSLINK-183 sync NCIP client #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just a call for each of the 8 initial NCIP types.
adamdickmeiss
requested review from
JanisSaldabols and
jakub-id
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a synchronous NCIP (NISO Circulation Interchange Protocol) client implementation that supports 8 NCIP message types: LookupUser, AcceptItem, DeleteItem, RequestItem, CancelRequestItem, CheckInItem, CheckOutItem, and CreateUserFiscalTransaction.
- Implements the NcipClient interface with methods for all 8 NCIP operations
- Adds comprehensive test coverage for all operations including success, failure, and edge cases
- Extends Directory schema to support NCIP configuration with operation modes (auto/manual/disabled)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| broker/ncipclient/ncipclient.go | Defines the NcipClient interface with 8 NCIP operations and custom error type |
| broker/ncipclient/ncipclient_impl.go | Implements the NcipClient interface with HTTP communication and response handling |
| broker/ncipclient/ncipclient_test.go | Comprehensive test suite covering all operations with various scenarios |
| illmock/directory/directory_api.yaml | Adds NCIP schema definition with configuration fields and operation modes |
| illmock/dirmock/directories.json | Adds sample NCIP configuration for mock testing |
| go.work.sum | Updates Go workspace checksums for dependencies |
adamdickmeiss
deleted the
CROSSLINK-183-extend-directory-with-ncip-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a call for each of the 8 initial NCIP types.