Skip to content

daemon keepalive: fix waitpid EINTR handling #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdickmeiss merged 1 commit into from
May 21, 2025
Merged

daemon keepalive: fix waitpid EINTR handling #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/daemon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,20 +137,19 @@ static void keepalive(void (*work)(void *data), void *data)
/* enable signalling in kill_child_handler */
child_pid = p;

p1 = waitpid(p, &status, 0);
// wait for child to finish and check status
while ((p1 = waitpid(p, &status, 0) == (pid_t ) (-1)) && errno == EINTR)
;

if (p1 == (pid_t) (-1))
{
yaz_log(YLOG_FATAL|YLOG_ERRNO, "waitpid");
break;
}

/* disable signalling in kill_child_handler */
child_pid = 0;

if (p1 == (pid_t)(-1))
{
if (errno != EINTR)
{
yaz_log(YLOG_FATAL|YLOG_ERRNO, "waitpid");
break;
}
continue;
}
if (p1 != p)
{
yaz_log(YLOG_FATAL, "p1=%d != p=%d", p1, p);
Expand Down
Loading