Affiliation-extras: Allow disabling contact emails for affiliations - #15
Open
duartegalvao wants to merge 1 commit into
Open
Affiliation-extras: Allow disabling contact emails for affiliations#15duartegalvao wants to merge 1 commit into
duartegalvao wants to merge 1 commit into
Conversation
duartegalvao
force-pushed
the
disable-contact-emails
branch
from
July 6, 2026 11:46
a04ef0b to
871dc7f
Compare
duartegalvao
force-pushed
the
disable-contact-emails
branch
from
July 6, 2026 12:05
871dc7f to
38e70ae
Compare
moliholy
reviewed
Jul 16, 2026
moliholy
left a comment
moliholy
left a comment
Contributor
There was a problem hiding this comment.
Mostly clean, one non-blocking note below.
| continue | ||
| inactive_emails = lst.get('inactive_emails', []) | ||
| if not set(inactive_emails) <= set(emails): | ||
| raise ValidationError('Inactive emails must belong to the contact list') |
Contributor
There was a problem hiding this comment.
Not wrapped for translation, and there are other cases in the plugin. Fine to keep here; might be worth a separate PR to wrap them all.
Member
Author
There was a problem hiding this comment.
This is purposeful since this message should never be displayed under normal conditions. Only if someone messes with the payloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to temporarily disable contact emails for affiliations.
Depends on: indico/indico#7638