Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citadel: Implement warning threshold #222

Merged

Conversation

GovernmentPlates
Copy link
Member

@GovernmentPlates GovernmentPlates commented Feb 12, 2024

This PR implements a warning message that is displayed to category admins when the total count of events in said category goes over a configurable threshold. The warning message will recommend admins to use groups instead.

TODO:

  • Configurable event warning threshold (plugin settings)
  • Better/More informative message (with styling)
  • Cleanup/Refactor

Preview:
image

@GovernmentPlates GovernmentPlates self-assigned this Feb 12, 2024
@GovernmentPlates GovernmentPlates marked this pull request as draft February 12, 2024 16:05
@GovernmentPlates GovernmentPlates force-pushed the Misc-Citadel-Event-Warnings branch from 30d1856 to 9eaea4a Compare February 12, 2024 17:48
And apply changes from review
@GovernmentPlates GovernmentPlates force-pushed the Misc-Citadel-Event-Warnings branch from 4300296 to b62b390 Compare February 12, 2024 18:59
@GovernmentPlates GovernmentPlates marked this pull request as ready for review February 12, 2024 19:05
citadel/indico_citadel/plugin.py Outdated Show resolved Hide resolved
citadel/indico_citadel/plugin.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster changed the title (Citadel) Add configurable category warnings threshold Citadel: Implement warning threshold Feb 13, 2024
@ThiefMaster ThiefMaster merged commit 9f7d6d9 into indico:master Feb 14, 2024
8 checks passed
@GovernmentPlates GovernmentPlates deleted the Misc-Citadel-Event-Warnings branch February 14, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants