fix saferpay: new saferpay ids are one digit longer #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks fine, I'll merge it and make a release tomorrow. PS: Your commit's email address is not linked to any github account. You may want to fix that so your commits are actually attributed to you. |
|
Thanks. Seems I haven't reviewed my github settings for a while :) |
ThiefMaster
force-pushed
the
patch_sixpay
branch
from
bd53559 to
c9468cc
Compare
ThiefMaster
approved these changes
Sep 24, 2024
|
(your PR with that fix was a good motivation to finally set up the CI needed to release specific plugins ;)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we received a new saferpay id last week. the new id is one digit longer than the validator supports. Don't think it will have negative impact on anyone having the validator allow one more digit.