Fix rspec failure on X-Inertia requests #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initial request and subsequent requests are handled with different renderers sometimes we may end up in situation where controller action may fail just in one of those cases:
https://github.com/inertiajs/inertia-rails/blob/master/lib/inertia_rails/renderer.rb#L19L28
This is exactly what happened on one of my work projects. Subsequent requests (with
X-Inertia
header were failing) but my rspec specs were all 🟢 .Naturally, I decided to add another spec that issues the request with
X-Inertia
header. It turned out that the rspec helper is not expecting that 😅 . This PR aims to resolve that and allow tests like the one below.