Return early when using router.on()
during SSR
#1715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
router.on()
it is always executed, this means the following won't work during SSR:Instead, we'd need to wrap this in a
onMounted
hook, or check if the document/window exists;But since
router.on()
is already just a wrapper fordocument.addEventListener()
I'd expect the wrapper to take care of that for you.A simple fix I've made here is to simply check if we're in ssr with the
isServer
constant, if it is we return an empty void function