Make isDirty reactive to defaults #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mochetts
commented
Feb 14, 2025
packages/react/src/useForm.ts
Outdated
| @@ -69,6 +70,10 @@ export default function useForm<TForm extends FormDataType>( | |||
| } | |||
| }, []) | |||
|
|
|||
| useEffect(() => { | |||
| setIsDirty(!isEqual(data, defaults)) | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mochetts
commented
Feb 14, 2025
packages/react/src/useForm.ts
Outdated
| @@ -111,6 +116,7 @@ export default function useForm<TForm extends FormDataType>( | |||
| setHasErrors(false) | |||
| setWasSuccessful(true) | |||
| setRecentlySuccessful(true) | |||
| setDefaults(data) | |||
There was a problem hiding this comment.
This should reset the isDirty prop back to false.
The isDirty prop is not reactive as it is for the vue package. This causes several issues such as the form staying as dirty even after submitting a successful request. Or even after setting the defaults to be the same as the form data: inertiajs#2109
|
Thank you, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The isDirty prop is not reactive as it is for the vue package.
This causes several issues such as the form staying as dirty even after a successful submit.
Reason
The defaults are not being set as the data after a successful submission.
Solution
Set the defaults as the submitted data upon a sucessful submit.
See vue3 implementation as it's doing exactly that.