[2.x] Fix useForm typehinting issue #2273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking a stab at this @noxasch. I just ran into this problem too. Unfortunately, this PR doesn't seem to solve the problem. I believe the type with the issue is |
noxasch
force-pushed
the
fix-useform-typehinting-issue
branch
from
7c9ddf0 to
d50f5f0
Compare
noxasch
force-pushed
the
fix-useform-typehinting-issue
branch
from
d50f5f0 to
7844175
Compare
noxasch
force-pushed
the
fix-useform-typehinting-issue
branch
from
cdfa0cf to
d093a5f
Compare
noxasch
changed the title
noxasch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2188 which introduce from #2060.
This PR should cover all 3 framework (react, svelte, vue3) issue with typescript.
Update
test-apppages for each framework that useuseFormto use typescript to validate this.