Skip to content

fix crash with WAGTAILADMIN_COMMENTS_ENABLED = False #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiogoMarques29 merged 1 commit into from
Oct 24, 2025
Merged

fix crash with WAGTAILADMIN_COMMENTS_ENABLED = False #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion wagtail_modeltranslation/patch_wagtailadmin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ def _patch_panels(self, panels_list, related_model=None):
if isinstance(panel, PanelPlaceholder):
# Create an instance of the panel according to the specs of the placeholder
real_panel = panel.construct()
initiated_panels_list.append(real_panel)
# `real_panel` will be none for the `CommentPanelPlaceholder` subclass if
# `WAGTAILADMIN_COMMENTS_ENABLED = False` is set in the settings
if real_panel is not None:
initiated_panels_list.append(real_panel)
elif isinstance(panel, str):
field = current_patching_model._meta.get_field(panel)
if isinstance(field, ManyToOneRel):
Expand Down