docs: fix typo and other observations #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
commented
Dec 3, 2025
| -d '{"jsonrpc":"2.0","method":"eth_getBalance","params":["0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266","latest"],"id":1}' | ||
| ``` | ||
|
|
||
| **Send a transaction:** |
Collaborator
Author
There was a problem hiding this comment.
Doesn't work in the testnet setup, as it requires the sender's private keys to be available in the EVM client.
mpoke
reviewed
Dec 3, 2025
| </details> | ||
|
|
||
| Running this command should results in the following output: | ||
| Running this command should result in the following output: |
ljoss17
reviewed
Dec 8, 2025
| **Verify installations:** | ||
| ```bash | ||
| rustc --version # Should show rustc 1.85+ | ||
| rustc --version # Should show rustc 1.88+ |
Contributor
There was a problem hiding this comment.
Which crates requires 1.88+?
I am able to verify MSRV 1.85 for:
- app
- cli
- engine
- utils
- types
We should also update https://github.com/informalsystems/emerald/blob/main/Cargo.toml#L18 accordingly
Contributor
There was a problem hiding this comment.
Oh and I see we are missing rust-version = { workspace = true } here https://github.com/informalsystems/emerald/blob/main/cli/Cargo.toml#L8
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos and addresses other observations found while reviewing the docs and running a local testnet.