feat(cli): println! to tracing logs migration
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoss17
reviewed
Dec 18, 2025
Contributor
ljoss17
left a comment
ljoss17
left a comment
There was a problem hiding this comment.
Some small formatting comments for the logs
Contributor
Regarding this, yes ideally I feel like this should be migrated to |
bastienfaivre
changed the title
println!println! to tracing logs migration
Collaborator
Author
|
@ljoss17, I fixed your comments and migrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #121.
I replaced all
println!statements with tracing logs for the testnet subcommand. @ljoss17 let me know if this is what you had in mind.Moreover, I observe two more files where
println!is used:utils/src/poa.rs: 21 occurrencescli/src/cmd/show_pubkey.rs: 1 occurrence (show public key command)Should we also use tracing logs for these, too?