Merge pull request #2223 from ing-bank/fix/types

fix: type errors for SlotMixin.test.js
ing-bank · Mar 18, 2024 · fe61687 · fe61687
2 parents e4e6159 + ba8ac91
commit fe61687
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/ui/CHANGELOG.md b/packages/ui/CHANGELOG.md
@@ -7,6 +7,7 @@
 - [core] allow SlotRerenderObject to first render on connectedCallback via `firstRenderOnConnected`
 
 ### Patch Changes
+- [tests] fix type errors for SlotMixin.test.js
 - [input-tel-dropdown] use ScopedElementsMixin in to run test-suite with select-rich
 - [core] add Firefox to browserDetection
 - [overlays] skip local-positioning tests for Firefox, and added a todo to fix later

diff --git a/packages/ui/components/core/test/SlotMixin.test.js b/packages/ui/components/core/test/SlotMixin.test.js
@@ -1,6 +1,5 @@
 import sinon from 'sinon';
 import { defineCE, expect, fixture, fixtureSync, unsafeStatic, html } from '@open-wc/testing';
-// @ts-expect-error
 import { ScopedElementsMixin } from '@open-wc/scoped-elements/lit-element.js';
 import { SlotMixin } from '@lion/ui/core.js';
 import { LitElement } from 'lit';
@@ -516,6 +515,7 @@ describe('SlotMixin', () => {
         class extends ScopedElementsMixin(SlotMixin(LitElement)) {
           static get scopedElements() {
             return {
+              // @ts-expect-error
               ...super.scopedElements,
               'scoped-elm': ScopedEl,
             };
@@ -548,10 +548,10 @@ describe('SlotMixin', () => {
       class ScopedEl extends LitElement {}
 
       const tagName = defineCE(
-        // @ts-expect-error
         class extends ScopedElementsMixin(SlotMixin(LitElement)) {
           static get scopedElements() {
             return {
+              // @ts-expect-error
               ...super.scopedElements,
               'scoped-el': ScopedEl,
             };