Fix/remove file

[DannyMoerkerke]

What I did

1. lion-selected-filelist: restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

[changeset-bot]

🦋 Changeset detected

Latest commit: bee1169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lion/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tlouisse]

Yeah, noticed this before as well. Would be nice if there was a faling test for this.

I don't think it's a good idea to leak private events, though.

We could replace this:

lion/packages/ui/components/input-file/src/LionInputFile.js

Line 185 in a19e02c

this.addEventListener(

with:

get _fileListNode() {
  return Array.from(this.children).filter(child => child.slot === 'selected-file-list');
}

connectedCallback() {
  super.connectedCallback();
  
  // ...
  
  this._fileListNode.addEventListener(
    'file-remove-requested',
     /** @type {EventListener} */ (this._onRemoveFile),
  );
}

// and remove on disconnected

The event then only needs to communicate with its parent without "polluting" the rest of the dom tree.

[DannyMoerkerke]

This still doesn't work without composed: true and bubbles: true. We could add event.stopPropagation to prevent it from bubbling up further.