Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlays): add aria-hidden to arrow #2030

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

vlaraort
Copy link
Contributor

@vlaraort vlaraort commented Jul 5, 2023

What I did

  1. Add aria-hidden to overlay arrows, as discussed in Hide overlay arrow to screen readers #2014

fix: #2014

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: d6402e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vlaraort vlaraort force-pushed the bugfix/aria-hidden-arrow branch 2 times, most recently from 02ff85a to 11b4b69 Compare July 5, 2023 15:26
@gerjanvangeest
Copy link
Member

Hi @vlaraort, thanks for making the PR 💪 !

Could you also add a changeset (npm run changeset), so it ends up in our changelog?

@vlaraort
Copy link
Contributor Author

vlaraort commented Jul 7, 2023

@gerjanvangeest done!

@gerjanvangeest gerjanvangeest merged commit 5eafa1f into ing-bank:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide overlay arrow to screen readers
2 participants