Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minimum click area and minimal html #2034

Closed
wants to merge 1 commit into from
Closed

Fix: minimum click area and minimal html #2034

wants to merge 1 commit into from

Conversation

Hornebom
Copy link

@Hornebom Hornebom commented Jul 9, 2023

What I did

While going through the repository, I noticed that the styling of the LionButton makes sure that the click area is always at least 44x44px. This neat detail is not in place for the LionSwitchButton. To make this particular css available for both components, I extracted it into a dedicated file and imported it into LionButton and LionSwitchButton.

Further I noticed that the LionSwitchButton contains more html elements than actually needed. The styles from the .btn and .switch-button__track can easily be used on :host. In that way there's less css to maintain and less html in the dom.

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

⚠️ No Changeset found

Latest commit: 62012ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Hornebom Hornebom closed this Jul 24, 2023
@Hornebom Hornebom deleted the fix/switch--click-area--minimal-html branch July 24, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants