feat: parsing body for failed ajax responses

[jorenbroekema]

What I did

1. Add automatic response body parsing for fetchJson failed responses
2. Add test for manually parsing body for fetch failed responses

[changeset-bot]

🦋 Changeset detected

Latest commit: 7e410f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lion/ajax	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[thepassle]

This contains a bug when using ajaxApi.fetchJson()

fechJson internally calls this.fetch, where parseErrorResponse is set to true:

const response = await this.fetch(info, jsonInit, true);

However, it doesnt first call fetch on the Ajax class, but on the AjaxApi class, which signature looks like this:

fetch(apiPath, init) {} 

The AjaxApi class's fetch method then calls:

super.fetch(getApiUrl(apiPath), {
  credentials: "include",
  ...init,
});

reaching Ajax's fetch method, where parseErrorResponse default to false:

async fetch(info, init, parseErrorResponse = false) {}

Meaning that it doesn't parse the body for failed requests when using AjaxApi. Can you take a look at this? :)

[jorenbroekema]

@thepassle this is related to ING's extension of @lion/ajax right? I got a task on my list to perpetuate this change to the ING extension and make sure the param is passed

[thepassle]

Ah yes indeed, this is in AjaxApi which is in ING. My bad. Still need to fix it there too though :)