Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix selection of best categories bucketers.py #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josecaloca
Copy link

Currently, when encoding_method == "ordered" the features are ordered based on the proportion of events in the target variable in ascending order.

Ideally, we would like to keep the categories with highest proportion of events separately, and those with lowest volume of events, then to be dropped

by doing

normalized_counts = normalized_counts[-self.max_n_categories:]

we ensure to keep the top frequent categories

Currently, when encoding_method == "ordered" the features are ordered based on the proportion of events in the target variable in ascending order.

Ideally, we would like to keep the categories with highest proportion of events separately, and those with lowest volume of events, then to be dropped

by doing 

normalized_counts = normalized_counts[-self.max_n_categories:]

we ensure to keep the top frequent categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant