use caffeine in CachedStore and adapt ManagedInternalForm for state p… #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
commented
Oct 22, 2024
| public CachedStore(Store<KEY, VALUE> store, CaffeineSpec caffeineSpec) { | ||
| this.store = store; | ||
| cache = Caffeine.from(caffeineSpec) | ||
| // .recordStats(() -> new MetricsStatsCounter(metricRegistry, "cache."+store.toString())) |
There was a problem hiding this comment.
Metrics hinzufügen
thoniTUB
commented
Oct 22, 2024
backend/src/main/java/com/bakdata/conquery/models/query/ManagedQuery.java
Outdated
Show resolved
Hide resolved
awildturtok
approved these changes
Oct 22, 2024
backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/io/storage/xodus/stores/CachedStore.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/io/storage/xodus/stores/XodusStore.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/auth/basic/LocalAuthenticationRealm.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/execution/ManagedExecution.java
Outdated
Show resolved
Hide resolved
| @@ -258,6 +254,9 @@ public synchronized void finish(ExecutionState executionState) { | |||
|
|
|||
| getExecutionManager().updateState(getId(), executionState); | |||
|
|
|||
| // Persist state of this execution | |||
| metaStorage.updateExecution(this); | |||
There was a problem hiding this comment.
wird finish nicht immer vom execution Manager aufgerufen, so dass der das schon machen sollte?
| }/** | ||
| * Cache for execution states. | ||
| */ | ||
| private final Cache<ManagedExecutionId, State> executionStates = |
backend/src/main/java/com/bakdata/conquery/models/query/ManagedQuery.java
Outdated
Show resolved
Hide resolved
| @@ -144,6 +145,7 @@ private static Map<String, AbsoluteFormQuery> createTimeStratifiedQueries(Range< | |||
|
|
|||
| @Nullable | |||
| @Override | |||
| @JsonIgnore | |||
|
@awildturtok Kannst du bitte nochmal drüber schauen, das Laden der Stores ist jetzt konfigurierbar, wo bei der Bucket und CBlock dennoch bei jedem Start direkt geladen werden durch den BucketManager Und ich habe den LoadStorageTask abgeändert, so dass er im ManagerNode, ShardNode und Standalone genutzt werden kann. |
# Conflicts: # backend/src/main/java/com/bakdata/conquery/commands/ManagerNode.java # backend/src/main/java/com/bakdata/conquery/models/forms/managed/ExternalExecution.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ersistence