Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Have bootstrap command load config file changes during execution (issue #13) #14

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

pbanos
Copy link
Contributor

@pbanos pbanos commented Sep 16, 2019

Description

  • Config loading stores the time at which the file is read
  • Added utils.ReloadConfig method to reload config, that informs not only on the current config, but if it was updated (and if there was an error)
  • Refactor bootstrapping command so that the periodical (default) mode detects changes to config and can change to run-once mode. The reloading also affects to the interval, splay and applyAfterIterations parameters.

Related Issue

Issue #13

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pbanos pbanos self-assigned this Sep 16, 2019
Copy link
Contributor

@lttito lttito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@ptemmer ptemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pbanos pbanos merged commit 20beb35 into develop Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants