Skip to content

new push parameters: --tag / --tag-refresh #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oboukili
Copy link

Hello,

This PR introduces --tag and --tag-refresh parameters to the push command:

  The `--tag` option will apply a given (non-annotated) tag to the specified
  subrepos' upstream HEAD, provided that they were staged for changes, leaving
  the parent repository unchanged.

  The `--tag-refresh` will apply the given tag (with `--tag`) to all specified
  subrepos' upstream HEAD even if they were not staged for changes.

I had a need to push to multiple subrepos, passing on a common information. I thought a tag would be a good way to do it.

This should also resolve issue #188.

I also fixed some cleaning bugs with the delete-branch -> delete-worktree calls.
I've based of this PR on the release/0.4.0 branch.

Cheers,

@oboukili
Copy link
Author

I would appreciate some help with the CI tests failing :) I don't know where to look at.

@oboukili
Copy link
Author

@grimmySwe or @ingydotnet would you have some time to give me a hand?

@JacopKane
Copy link

This PR sounds great for pushing tags altogether, wish it could have a go

@oboukili
Copy link
Author

Still no news, hard at work I presume?
Cheers

@ingydotnet ingydotnet closed this Nov 11, 2018
@oboukili
Copy link
Author

Why was it closed?

@ingydotnet
Copy link
Owner

@oboukili hmm. Looks like my fault. Since 0.4.0 is now on master I deleted the release/0.4.0 branch, and that seems to have auto-closed this.

Can you see if it is possible to re-target master?

I wonder how many other PRs I closed by doing this.

@grimmySwe take note...

@ingydotnet
Copy link
Owner

I can try to repush the release/0.4.0 branch and see what happens to the 7 closed PRs.

@ingydotnet ingydotnet reopened this Nov 11, 2018
@ingydotnet
Copy link
Owner

I re-pushed release/0.4.0 and clicked the 'Reopen pull request' button.

This PR still needs to re-target master I would think. @oboukili let me know if you figure out how to do that.

I'll reopen the others for now, and wait for more clarity.

@oboukili oboukili changed the base branch from release/0.4.0 to master November 13, 2018 08:56
@oboukili
Copy link
Author

@ingydotnet alright I changed the PR's base branch to target master instead.

@oboukili oboukili closed this May 9, 2020
@admorgan
Copy link
Collaborator

admorgan commented May 9, 2020

Was this closed because you were tired of waiting or because you found a better solution? I am still working through the backlog and this seems like a great patch.

@oboukili
Copy link
Author

Hello Indeed it has been more than a year, I was doing some old PR cleanup, I can reopen it if it is still of some interest.

@oboukili oboukili reopened this May 10, 2020
@twpedersen
Copy link

This would be a great feature!

subrepos' upstream HEAD, provided that they were staged for changes, leaving
the parent repository unchanged.

The `--tag-refresh` will apply the given tag (with `--tag`) to all specified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I read this, it would be the equivalent to git subrepo push --tag --all --force. Am I correct? If so I prefer calling out all the parameters to --tag-refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants