-
Notifications
You must be signed in to change notification settings - Fork 277
new push parameters: --tag / --tag-refresh #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…st-cleaning bugs with worktrees/branches.
I would appreciate some help with the CI tests failing :) I don't know where to look at. |
@grimmySwe or @ingydotnet would you have some time to give me a hand? |
This PR sounds great for pushing tags altogether, wish it could have a go |
Still no news, hard at work I presume? |
Why was it closed? |
@oboukili hmm. Looks like my fault. Since 0.4.0 is now on master I deleted the Can you see if it is possible to re-target master? I wonder how many other PRs I closed by doing this. @grimmySwe take note... |
I can try to repush the |
I re-pushed This PR still needs to re-target master I would think. @oboukili let me know if you figure out how to do that. I'll reopen the others for now, and wait for more clarity. |
@ingydotnet alright I changed the PR's base branch to target master instead. |
Was this closed because you were tired of waiting or because you found a better solution? I am still working through the backlog and this seems like a great patch. |
Hello Indeed it has been more than a year, I was doing some old PR cleanup, I can reopen it if it is still of some interest. |
This would be a great feature! |
subrepos' upstream HEAD, provided that they were staged for changes, leaving | ||
the parent repository unchanged. | ||
|
||
The `--tag-refresh` will apply the given tag (with `--tag`) to all specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I read this, it would be the equivalent to git subrepo push --tag --all --force
. Am I correct? If so I prefer calling out all the parameters to --tag-refresh.
Hello,
This PR introduces --tag and --tag-refresh parameters to the push command:
I had a need to push to multiple subrepos, passing on a common information. I thought a tag would be a good way to do it.
This should also resolve issue #188.
I also fixed some cleaning bugs with the delete-branch -> delete-worktree calls.
I've based of this PR on the release/0.4.0 branch.
Cheers,