Skip to content

Adds the ability to --gpg-sign new commits to the upstream #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edvinassabaliauskas
Copy link

@edvinassabaliauskas edvinassabaliauskas changed the title Adds the ability to --gpg-sign new commits to the upstream Adds the ability to --gpg-sign new commits to the upstream Mar 26, 2024
@kuwannet
Copy link

I’ve been playing with this and have some comments…

  1. It would be good to honor whether commit.gpgsign=true has been set via git config and automatically pass -S or --gpg-sign to the commands that need it. Per the git documentation:

    To configure your Git client to sign commits by default for a local repository, in Git versions 2.0.0 and above, run git config commit.gpgsign true. To sign all commits by default in any local repository on your computer, run git config --global commit.gpgsign true.

    When you have commit.gpgsign=true set and are used to having commits always signed automatically, it’s easy to forget to add the option to the git subrepo … commands.

  2. It would also be nice to use the -S option as a synonym for --gpg-sign as is supported by git itself:

    -S[<keyid>], --gpg-sign[=<keyid>], …
        GPG-sign commits. The keyid argument is optional and defaults to the committer identity; if specified, it must be stuck to the option
        without a space…
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for GPG signed commits on upstream repo
2 participants