Skip to content

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Oct 3, 2025

this PR is really cool:

  • add service name to router, defaulting to ajj
  • comply with OTEL semantic conventions (see exception in README)
  • axum router now propagates traceparent details to the span :)
  • add metrics for requests received, processed, succeeded, errors, and responses sent/omitted
  • metric labels by service name and method
  • improve tracing span propagation to include more request lifecycle within the request span
  • delegate handler implementation to a macro to DRY it as much as possible
  • Simplify ResponsePayload by making a transparent wrapper around Result

Copy link
Member Author

prestwich commented Oct 3, 2025

@prestwich prestwich force-pushed the prestwich/enhance-otel branch 4 times, most recently from 14b8080 to a08b2e1 Compare October 3, 2025 15:47
@prestwich prestwich force-pushed the prestwich/enhance-otel branch from a08b2e1 to c32f7c6 Compare October 3, 2025 15:48
@prestwich prestwich marked this pull request as ready for review October 3, 2025 16:03
@prestwich prestwich changed the title feat: enhance otel implementation by setting more span info on request receipt feat: OTEL semantic convention compliance and req/resp metrics Oct 9, 2025
@prestwich prestwich force-pushed the prestwich/enhance-otel branch from c4ee6e0 to 1d05045 Compare October 9, 2025 15:33
@prestwich prestwich requested a review from Evalir October 10, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant