perf(rpc): use CacheDB for wrapping StateProviderDatabase
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reth also does this [e.g](https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc/src/eth/bundle.rs#L151). This makes sense, as for RPC we're only accessing state and more complex calls might need accessing the same parts of the trie. We can save a bunch of I/O time by caching the results (and state changes when tracing, which once implemented should be faster with this layer).
|
state already internally caches, this would make sense iff we deconstructed the https://docs.rs/revm/latest/revm/database/struct.State.html https://docs.rs/revm-database/7.0.4/src/revm_database/states/state.rs.html#190-212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reth also does this e.g.
This makes sense, as for RPC we're only accessing state and more complex calls might need accessing the same parts of the trie. We can save a bunch of I/O time by caching the results (and state changes when tracing, which once implemented should be faster with this layer).