Skip to content

chore: downgrade some traces #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prestwich merged 1 commit into from
Dec 19, 2025
Merged

chore: downgrade some traces #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/sim/src/env/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use crate::{env::RollupEnv, outcome::SimulatedItem, HostEnv, SimCache, SimDb, Si
use core::fmt;
use std::{ops::Deref, sync::Arc};
use tokio::{select, sync::watch};
use tracing::{debug, info_span, trace};
use tracing::{debug, trace, trace_span};
use trevm::{
helpers::Ctx,
revm::{inspector::NoOpInspector, DatabaseRef, Inspector},
Expand Down Expand Up @@ -90,7 +90,7 @@ where

/// Run a simulation round, returning the best item.
pub async fn sim_round(&mut self, max_gas: u64, max_host_gas: u64) -> Option<SimulatedItem> {
let span = info_span!("sim_round", max_gas, max_host_gas);
let span = trace_span!("sim_round", max_gas, max_host_gas).or_current();
Copy link
Member

@Evalir Evalir Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is neat. avoids the event from happening outside from any span


// These will be moved into the blocking task.
let scope_span = span.clone();
Expand Down
2 changes: 1 addition & 1 deletion crates/sim/src/env/sim_env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ where
// Create a channel to send the results back.
let (candidates, mut candidates_rx) = mpsc::channel(self.concurrency_limit);

let outer = trace_span!("sim_thread", candidates = active_sim.len());
let outer = trace_span!("sim_thread", candidates = active_sim.len()).or_current();
let outer_ref = &outer;
let _og = outer.enter();

Expand Down