Open
Conversation
Member
|
This seems useful, I think we should go with a different name though as "incremental" has a whole bunch of connotations in this space due to "incremental view maintenance" being an important thing we need to do. I suggest "DigestBuilder". |
zicklag
force-pushed
the
feat/sedimentree-incremental-digest
branch
2 times, most recently
from
1723879 to
1d4f386
Compare
zicklag
changed the title
IncrementalDigest helper for building Digests.DigestBuilder helper.
Collaborator
Author
|
Updated the name. ✅ |
Member
|
I actually have no idea why the lint is failing there. Will look into it. |
Member
Clippy is angry that some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this handy while trying to use sedimentree in a key-value store use-case.