Fix admin revocation bug that an admin can only revoke itself#146
Open
LiangrunDa wants to merge 1 commit intoinkandswitch:mainfrom
Open
Fix admin revocation bug that an admin can only revoke itself#146LiangrunDa wants to merge 1 commit intoinkandswitch:mainfrom
LiangrunDa wants to merge 1 commit intoinkandswitch:mainfrom
Conversation
LiangrunDa
force-pushed
the
fix-admin-revoke
branch
from
39ab946 to
b3e4eee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where an admin can only revoke itself, due to the check in revoke_member. Test
test_admin_revoke_membercan reproduces this bug and also serves as a correctness test for this fix.Further, the proof chain check incorrectly uses
proof.as_ref()as next head instead ofnext_proof.as_ref(). This bug is fixed as well.