Open
Conversation
sequencer.voting → is a boolean (True if it’s a voter, False if not). int(not sequencer.voting) → flips it, then casts to 0/1. If sequencer.voting=True → not True=False → int(False)=0. If sequencer.voting=False → not False=True → int(True)=1. So basically: 0 means "voter" 1 means "non-voter" This inversion suggests your membership[...]["suffrage"] is encoded the opposite way (maybe 0 = voter, 1 = non-voter). But the inversion is confusing and easy to misinterpret. If someone reading the code assumes True = voter, they’ll think the comparison is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sequencer.voting → is a boolean (True if it’s a voter, False if not). int(not sequencer.voting) → flips it, then casts to 0/1.
If sequencer.voting=True → not True=False → int(False)=0. If sequencer.voting=False → not False=True → int(True)=1.
So basically:
0 means "voter"
1 means "non-voter"
This inversion suggests your membership[...]["suffrage"] is encoded the opposite way (maybe 0 = voter, 1 = non-voter).
But the inversion is confusing and easy to misinterpret. If someone reading the code assumes True = voter, they’ll think the comparison is wrong.
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata