Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: Introduce indexes validity check #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

abeglu
Copy link
Contributor

@abeglu abeglu commented Sep 19, 2024

No description provided.

@abeglu abeglu requested a review from seqizz September 19, 2024 09:44
@abeglu abeglu self-assigned this Sep 19, 2024
@kofrezo
Copy link
Contributor

kofrezo commented Sep 19, 2024

We have this check already:

$ mon -c postgres_invalid_indexes_eu1_game
postgres_invalid_indexes_eu1_game - OK - All indexes are valid

@abeglu
Copy link
Contributor Author

abeglu commented Sep 19, 2024

Currently, we're creating a separate command for each database, but by using this script, we can check multiple databases with a single command.

Copy link
Contributor

@seqizz seqizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess single check is a lot cleaner on monitoring side, so LGTM. But please process this with a formatter like ruff. We should start using f-strings at least at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants