-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin archive workflow #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the massive delay. I wanted to take time because there are quite some things that can be improved.
Apart from the line comments, please also update the documentation accordingly. Thanks!
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
@Chrico suggested replacing |
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the changes! LGTM.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
The products team is using multiple individual processes for plugin archive generation. There have been attempts to unify this, but the fact remains that these processes are maintained for each plugin separately.
What is the new behavior (if this is a feature change)?
The ability to share a unified workflow across multiple products would mean a substantial improvement in our workflows and maintenance efforts.
Please note that this is strictly an "build" workflow and not a "release" workflow and should not be confused with one. It is very common for us to create a
my-plugin-JIRA-123.zip
build off some feature branch in order to pass on an issue to QA. Given that this constitutes ~98/100 builds that we will be doing, you could go as far as to say that is the primary objective.To implement it, I have tried to stay close to existing practices and using existing tools where possible
wp dist-archive
command for these reasons:rsync --exclude-from
) for reducing clutter from resulting archivesDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Please feel invited and welcome to squash-merge this PR. Next time I will try to setup something I can more easily replicate with
nectos/act
, but for this instance, I just had to do a LOT of trial&error commits