feat: add /pools/retiring endpoint #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate-retiring-endpoint
sandtreader
reviewed
Jul 24, 2025
modules/spo_state/src/state.rs
Outdated
| @@ -114,6 +114,24 @@ impl State { | |||
| self.current().map(|state| state.spos.iter().collect()) | |||
| } | |||
|
|
|||
| /// Get pools that will be retired in the upcoming epochs | |||
| pub fn get_retiring_pools(&self) -> Option<Vec<PoolRetirement>> { | |||
There was a problem hiding this comment.
Just wondering why this is an Option<> - feels like that's an implementation detail and it could return a (definite) empty Vec if there aren't any?
There was a problem hiding this comment.
Yeah, that makes sense. 👍🏼
|
Nice! Looks great - just one pernickity question about returning an Option<> but happy to merge if you don't agree |
…ot Option and improve response handling
…eate-retiring-endpoint
- Updated handle_spo function to also handle requests for retiring pools. - Removed direct handling of retiring pools from the main REST request handling.
golddydev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
/pools/retiringendpoint to get all pools which will be retired in upcoming epochs.Changes
/pools/retiringendpoint tospo_statemodule'ssporest handler.PoolRetirementschema.get_retiring_poolsfunction.Related Issue
#95