-
Notifications
You must be signed in to change notification settings - Fork 298
[DDW-106] Wallet import feature #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-106] Wallet import feature #1956
Conversation
…put-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…put-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…b.com/input-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…put-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…ature' into feature/ddw-106-wallet-import-feature
…put-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…put-output-hk/daedalus into feature/ddw-106-wallet-import-feature
…b.com/input-output-hk/daedalus into feature/ddw-106-wallet-import-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, Daedalus team 🚀
@@ -35,6 +40,11 @@ | |||
} | |||
|
|||
:global { | |||
.SimpleFormField_root { | |||
.SimpleFormField_error { | |||
top: 47px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakovkaravelov this should be at least 52px (I think) -> so it should be around 6px distance between the input field and the error
This PR implements "Wallet Import" feature.
Todos
export-wallets
utility (export legacy wallets in a friendly way for automatic import in cardano-wallet cardano-sl#4278)Implement tests- To be implemented within DDW-154Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board