Skip to content

[DDW-1220] Update cardano-node to 8.1.1 (via cardano-wallet) #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[DDW-1220] Update cardano-node to 8.1.1 (via cardano-wallet) #3133

wants to merge 2 commits into from

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jun 26, 2023 •
edited
Loading

This PR updates cardano-node to 8.1.1

⚠️ DO NOT MERGE: blocked until:

Todos

  • switch to proper cardano-wallet release

Screenshots

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus self-assigned this Jun 26, 2023
@michalrus michalrus force-pushed the chore/ddw-1220-cardano-node-8.1.1 branch 5 times, most recently from 1e3a5e6 to d45c905 Compare June 26, 2023 14:05
@michalrus michalrus requested review from a team June 26, 2023 14:06
@michalrus michalrus force-pushed the chore/ddw-1220-cardano-node-8.1.1 branch 3 times, most recently from 145c23c to f833791 Compare June 26, 2023 15:08
@michalrus michalrus force-pushed the chore/ddw-1220-cardano-node-8.1.1 branch from 4da19c7 to 30c3ac8 Compare August 11, 2023 10:37
@michalrus michalrus changed the base branch from develop to fix/ddw-1227-hydra-oom August 11, 2023 10:38
Base automatically changed from fix/ddw-1227-hydra-oom to develop August 16, 2023 08:34
@michalrus
Copy link
Member Author

Superseded by #3152.

@michalrus michalrus closed this Mar 28, 2024
@michalrus michalrus deleted the chore/ddw-1220-cardano-node-8.1.1 branch May 17, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michalrus michalrus

Labels
cardano-node chore DO NOT MERGE ⏳release-vNext
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalrus @marcin-mazurek