Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: move notify-on-failure to a dedicated workflow #2262

Merged
merged 1 commit into from
Jan 30, 2025
Merged

CI: move notify-on-failure to a dedicated workflow #2262

merged 1 commit into from
Jan 30, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 29, 2025 •
edited
Loading

Content

This PR introduces a new manual workflow to test email alert delivery when an error occurs in the nightly dispatcher.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2251

@dlachaume dlachaume self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 30s ⏱️ -4s
1 569 tests ±0  1 569 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 843 runs  ±0  1 843 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit da23b62. ± Comparison against base commit 3b6a2a0.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/notify-on-failure.yml Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 14:05 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2251/manual-workflow-for-email-alerts branch from b729fef to 82fd5bf Compare January 29, 2025 14:20
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 14:29 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2251/manual-workflow-for-email-alerts branch from 82fd5bf to 5a29df9 Compare January 29, 2025 14:30
@dlachaume dlachaume force-pushed the dlachaume/2251/manual-workflow-for-email-alerts branch from 5a29df9 to da23b62 Compare January 29, 2025 14:35
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 14:43 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 31aa286 into main Jan 30, 2025
43 of 44 checks passed
@dlachaume dlachaume deleted the dlachaume/2251/manual-workflow-for-email-alerts branch January 30, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a manual workflow to test emails alert delivery
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud