Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing workflow_call trigger on Test Notify on Failure workflow #2267

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 31, 2025

Content

This PR includes a fix for the test-notify-on-failure workflow to allow it to be triggered by the Nightly Dispatcher workflow.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Jan 31, 2025
Copy link

Test Results

    4 files  ±0     52 suites  ±0   10m 25s ⏱️ +2s
1 569 tests ±0  1 569 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 843 runs  ±0  1 843 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5ea3289. ± Comparison against base commit 31aa286.

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 3e6e02a into main Jan 31, 2025
47 of 49 checks passed
@dlachaume dlachaume deleted the dlachaume/fix-test-notify-on-failure-workflow branch January 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants