-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Kafka FUP Phase I #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -52,6 +52,7 @@ dependencies = [ | |||
"opentelemetry-api>=1.27.0", | |||
"opentelemetry-semantic-conventions>=0.48b0", | |||
"typing_extensions>=4.12.2", | |||
"pyyaml>=6.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is pyyaml
a dependency for the tracer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GSVarsha, that's because we need to read YAML configuration files now. This is part of the design.
I don't like the idea of having it as one of the main dependencies of our package. Perhaps we can add it as an extra installation option. The users would then execute something like the following command if they want to use the Kafka filtering:
pip install instana[yaml]
e73b776
to
e888524
Compare
Signed-off-by: Cagri Yonca <[email protected]>
Signed-off-by: Cagri Yonca <[email protected]>
e888524
to
dda69a3
Compare
Changes:
configuration.yaml
file to filter specific services and methods now, as specified in the technical specification.configuration.yaml
file has the highest priority, usesend
for kafka-python andproduce
for confluent-kafka: