Skip to content

feat: Kafka FUP Phase I #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Kafka FUP Phase I #718

wants to merge 2 commits into from

Conversation

CagriYonca
Copy link
Contributor

Changes:

  • The customers are able to use configuration.yaml file to filter specific services and methods now, as specified in the technical specification.
  • Specific topics and specific methods can be filtered using one of the below, configuration.yaml file has the highest priority, use send for kafka-python and produce for confluent-kafka:
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka:send,consume"
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka:produce,consume"
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka"
    • os.environ["INSTANA_IGNORE_ENDPOINTS_PATH"] = "configuration.yaml"

@CagriYonca CagriYonca self-assigned this Apr 10, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner April 10, 2025 12:58
@@ -52,6 +52,7 @@ dependencies = [
"opentelemetry-api>=1.27.0",
"opentelemetry-semantic-conventions>=0.48b0",
"typing_extensions>=4.12.2",
"pyyaml>=6.0.2",
Copy link
Contributor

@GSVarsha GSVarsha Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is pyyaml a dependency for the tracer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GSVarsha, that's because we need to read YAML configuration files now. This is part of the design.

I don't like the idea of having it as one of the main dependencies of our package. Perhaps we can add it as an extra installation option. The users would then execute something like the following command if they want to use the Kafka filtering:

pip install instana[yaml]

@CagriYonca CagriYonca force-pushed the ft/kafka-fup branch 4 times, most recently from e73b776 to e888524 Compare April 22, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants