Skip to content

Adds togglable attachaside feature #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UserXGnu
Copy link

Togglable feature to start attaching new clients to the stack area.

@UserXGnu UserXGnu changed the title Adds toggleble attachaside feature Adds togglable attachaside feature Oct 10, 2020
@con-f-use con-f-use added the enhancement New feature or request label Oct 10, 2020
@con-f-use
Copy link
Member

Can you add a config option in addition to the keyboard shortcut toggle?

@UserXGnu
Copy link
Author

UserXGnu commented Oct 10, 2020

Can you add a config option in addition to the keyboard shortcut toggle?

What do you mean by config option? Right now, in the config.h (config.def.h) you have the variable:

static int isattachaside

Which defaults to 0, in other words, the normal client attachment as usual, if the user wants it to attach to the stack by default always, it just need to modify this variable to 1 and the default behavior will to be attach to the stack rather than master.

@paperbenni
Copy link
Member

He means having it toggled through a config file. Modifying the source code is not exactly user friendly, runtime configuration is the goal

@UserXGnu
Copy link
Author

UserXGnu commented Oct 10, 2020

He means having it toggled through a config file. Modifying the source code is not exactly user friendly, runtime configuration is the goal

yes, I can do that, however I fear if everyone starts saving configs wherever they want it will become a mess. Do you guys already have a filepath where I can save and load data for config purposes? If yes, I can do it there! If not, we could come up with the config file name and path so that it becomes default for every new feature. (and old ones)

In that case, I would save the current status (if attachaside is to be default or not) and the keybinding the person wants to use, I guess that would be cool.

@paperbenni
Copy link
Member

paperbenni commented Oct 10, 2020

Nonono, sorry, I didn't mean you have to implement this before merging. The config file is going to be a universal system that works the same for all sorts of options. I'll probably merge this soon and add that after the fact.

@UserXGnu
Copy link
Author

Nonono, sorry, I didn't mean you have to implement this before merging. The config file is going to be a universal system that works the same for all sorts of options. I'll probably merge this soon and add that after the fact.

Cool, let me know if you happen to need any help! =-D

@paperbenni paperbenni added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants