-
Notifications
You must be signed in to change notification settings - Fork 38
Adds togglable attachaside feature #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can you add a config option in addition to the keyboard shortcut toggle? |
What do you mean by config option? Right now, in the config.h (config.def.h) you have the variable: static int isattachaside Which defaults to 0, in other words, the normal client attachment as usual, if the user wants it to attach to the stack by default always, it just need to modify this variable to 1 and the default behavior will to be attach to the stack rather than master. |
He means having it toggled through a config file. Modifying the source code is not exactly user friendly, runtime configuration is the goal |
yes, I can do that, however I fear if everyone starts saving configs wherever they want it will become a mess. Do you guys already have a filepath where I can save and load data for config purposes? If yes, I can do it there! If not, we could come up with the config file name and path so that it becomes default for every new feature. (and old ones) In that case, I would save the current status (if attachaside is to be default or not) and the keybinding the person wants to use, I guess that would be cool. |
Nonono, sorry, I didn't mean you have to implement this before merging. The config file is going to be a universal system that works the same for all sorts of options. I'll probably merge this soon and add that after the fact. |
Cool, let me know if you happen to need any help! =-D |
Togglable feature to start attaching new clients to the stack area.