Skip to content

Config documentaion #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

bob8677
Copy link
Contributor

@bob8677 bob8677 commented Apr 28, 2021

Here's what I did

  • Added some comments by keybinds, desktop keybinds, the TAGKEY macro, and mouse actions in config.def.h
  • I made a script to parse the comments I made so documentation can be generated without as much manual effort (just need to keep adding comments for the documentation to stay up to date)
  • Took the file that script outputs and combines it with a template for the manfile, so that keybinds in there stay up to date

If the scripts are not wanted I could remove that and just keep the labeling

@bob8677
Copy link
Contributor Author

bob8677 commented Apr 28, 2021

Codacy is wrong, all of the "issues" it finds are intentional, $d is for sed not a real variable

@con-f-use
Copy link
Member

con-f-use commented Apr 28, 2021

Okay first off, thanks for the work. It certainly is not nothing, and we appreciate it.

I'm all for that sort of thing, but we should have a discussion what the single source of truth for keybinds should be and what the places are that need updated when that source changes. As one example. instantNIX uses hotkeys.md which could be auto-generated form config.def.h, and there are a couple of other places where the hotkeys are hardcoded and probably shouldn't be. Also existing tools like doxygen, sphinx and the like exist for such things, so a bash script with a bunch of black sed-magic might not be the best solution.

This is also a part of a more general thing:
@paperbenni, as instantOS gets more and more contributors (which is awesome), we're also gaining more and more of the typical organizational challanges that come with teams developing software. Thinks like fragmentation of where the hotkeys are defined and documented, but also inconsistencies between how the different repos build their software and much more. From experience I know that, a good software architecture and tool choice early on is very important and saves incredible amounts of headache later. So, soon is probably a good time to look for looming issues and inconsistencies and do some architecturing.

@con-f-use con-f-use requested a review from paperbenni April 28, 2021 23:08
@con-f-use con-f-use added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 28, 2021
@con-f-use con-f-use self-assigned this Apr 28, 2021
@bob8677
Copy link
Contributor Author

bob8677 commented Apr 29, 2021

Also existing tools like doxygen, sphinx and the like exist for such things, so a bash script with a bunch of black sed-magic might not be the best solution.

I did not know about these tools and still have no clue how much they can do, but I am not sure they can do as much as a sed script, as least for the keybinds. If they can, thats great, otherwise I think it would make sense to maybe use doxygen or sphinx to start documentation and then edit the keybind parts with something like some sed-magic,
That being said I have no clue what I am talking about.

@con-f-use
Copy link
Member

Not bashing your work, nor even talking to you eclusively or anything. I'm not even against merging it. I'm just saying, the larger conversation might be worth having and having it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants