Skip to content

Fixes for chat eval layout and auto-scroll #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Collaborator

@jeff-phillips-18 jeff-phillips-18 commented Mar 17, 2025

Fixes Job logs displayed above the chat bot input box in case of "Single Input Box" is selected.
Fixes Chat eval chat bot doesn't scroll down automatically
Fixes Chat Eval UI not showing the status

Description

Additionally fixes some other layout/css issues in the Chat eval.
Uses the message area to inform the user if the model is not running or if it is loading.

Screen shots

image

image

image

image

image

image

image

ChatEvalResponse

@jeff-phillips-18 jeff-phillips-18 force-pushed the chat-eval-fixes branch 3 times, most recently from cb016b5 to 9e98465 Compare March 21, 2025 17:23
@Misjohns
Copy link
Collaborator

@jeff-phillips-18 @vishnoianil sorry I have a few questions here.

  • What does the green status icons represent? That the model is running?
  • What are the other status we could show here?
  • Why do we need to display a "good" icon. Adding a green check draws a users eye unnecessarily.
  • Could we display loading then only switch to an error icon if there's an issue with the model?
  • Can we not place the status icon inside the model dropdown menu? Look odd floating without any associated words.Here a PF component showing status toggle with helper text.
  • Is a icon enough to alert the user if a model isn't available? Maybe we should use something like an empty state that provides additional room for explanation and even how the user can resolve.

@jeff-phillips-18
Copy link
Collaborator Author

@jeff-phillips-18 @vishnoianil sorry I have a few questions here.

  • What does the green status icons represent? That the model is running?

Yes

  • What are the other status we could show here?

Error state for stopped or not running, spinner for loading/unloading

  • Why do we need to display a "good" icon. Adding a green check draws a users eye unnecessarily.

We currently show the state of the model server, if you think we only need error status or pending status we can do that

  • Could we display loading then only switch to an error icon if there's an issue with the model?

Yes

  • Can we not place the status icon inside the model dropdown menu? Look odd floating without any associated words.Here a PF component showing status toggle with helper text.

we could do that

  • Is a icon enough to alert the user if a model isn't available? Maybe we should use something like an empty state that provides additional room for explanation and even how the user can resolve.

The model server could be temporarily down. The user would no longer see their history if we showed an empty state instead.

@jeff-phillips-18 jeff-phillips-18 force-pushed the chat-eval-fixes branch 2 times, most recently from 215fce9 to 220e13f Compare April 8, 2025 16:13
@jeff-phillips-18
Copy link
Collaborator Author

@Misjohns Please take another look. Updated the screen shots above.

@Misjohns
Copy link
Collaborator

I need help understanding how the Free GPUs counter and the No GPUs Free status text relate. Questions below.

  • The GPU counter shows 0/1 which I take to mean I have 1 GPU available but it is not currently being utilized.
  • If I have a model selected on the left side, I assume that model would use that 1 available GPU. Is that accurate?
  • If I add a model to the right side then I'd expect to see the No GPUs Free since I only had 1 available which is being utilized by the model on the left. Is that correct?
  • The screen cap below shows both chat panels showing No GPUs Free but the counter shows 0/1. Why?

image

I think it is better to display the No GPUs Free to the right of the model selector and treat as a plain alert with an icon. I also think this should just be a warning.
image

Regarding the single input box. I believe that should be the default since the goal is to compare the responses between 2 models. I recommend we change the toggle to "Display two input boxes". Not sure if input boxes is the correct term, looks like most UIs refer to it as a message input. @kaedward thoughts on wording for that toggle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants