-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(camera-detection): add backend and frontend to detect laptop camera #658
Conversation
frontend backend divison
First version of backend
frontend backend
update backend
Update backend by using opencv to scan
frontend backend
@jeff14994 @ashworks1706 Another request, could you move your code under core services - https://github.com/intel-retail/core-services ? |
@NeethuES-intel I’ve fixed the issues above, let me know if it works, and then i’ll make a PR to the core-services repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small minor change.
.gitignore
Outdated
notebooks/__pycache__ | ||
|
||
src/extensions/camera_detection_service/venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add scanned_camera.txt here
scanned_cameras.txt
Outdated
@@ -0,0 +1,14 @@ | |||
actual_cameras = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this file to be not counted, add it in the gitignore above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates worked for me and it's much more responsive. Nice work!
@jeff14994 @ashworks1706 - can you please look at the comments left by reviewdog and address the errors? Once that is fixed your PR should be good to go. |
I've fixed that, let me know if it works |
@ejlee3 |
@jeff14994 Nice work! Can you please migrate this to core services so we can approve it and get it merged in? |
Issue resolved under intel-retail/core-services#23 |
This PR introduces backend and frontend functionality to detect cameras on the laptop.
Fixes #543