Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(camera-detection): add backend and frontend to detect laptop camera #658

Closed
wants to merge 64 commits into from

Conversation

jeff14994
Copy link

This PR introduces backend and frontend functionality to detect cameras on the laptop.

  • Implemented backend service to enumerate available cameras
  • Integrated frontend UI for real-time camera detection
  • Ensured cross-platform compatibility (Windows, Linux, macOS)

Fixes #543

@NeethuES-intel
Copy link
Contributor

@jeff14994 @ashworks1706 Another request, could you move your code under core services - https://github.com/intel-retail/core-services ?
This is a service that can be used by other repos. So you could move the entire camera_detection folder under that repo. Once all PR comments are addressed here, you can create another PR under core-services for merge.

@jeff14994
Copy link
Author

@jeff14994 @ashworks1706 Another request, could you move your code under core services - https://github.com/intel-retail/core-services ? This is a service that can be used by other repos. So you could move the entire camera_detection folder under that repo. Once all PR comments are addressed here, you can create another PR under core-services for merge.

@NeethuES-intel I’ve fixed the issues above, let me know if it works, and then i’ll make a PR to the core-services repo

Copy link
Contributor

@NeethuES-intel NeethuES-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small minor change.

.gitignore Outdated
notebooks/__pycache__

src/extensions/camera_detection_service/venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add scanned_camera.txt here

@@ -0,0 +1,14 @@
actual_cameras = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this file to be not counted, add it in the gitignore above

Copy link
Contributor

@NeethuES-intel NeethuES-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
When I run multiple cameras (shown above), the UI becomes laggy or unresponsive. The colors also make it hard to read the cameras available. I tested with 2 usb cameras - a realSense camera (which has multiple camera channels) and a standard usb camera.

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates worked for me and it's much more responsive. Nice work!

@ejlee3
Copy link
Contributor

ejlee3 commented Feb 7, 2025

@jeff14994 @ashworks1706 - can you please look at the comments left by reviewdog and address the errors? Once that is fixed your PR should be good to go.
image

@jeff14994
Copy link
Author

@jeff14994 @ashworks1706 - can you please look at the comments left by reviewdog and address the errors? Once that is fixed your PR should be good to go. image

I've fixed that, let me know if it works

@ejlee3
Copy link
Contributor

ejlee3 commented Feb 7, 2025

Looks like you fixed one of the issues, but I still see 2 more.
image

@jeff14994
Copy link
Author

Looks like you fixed one of the issues, but I still see 2 more.

image

@ejlee3
I fixed the wrong one, it should probably work now

@ejlee3
Copy link
Contributor

ejlee3 commented Feb 7, 2025

@jeff14994 Nice work! Can you please migrate this to core services so we can approve it and get it merged in?

@NeethuES-intel
Copy link
Contributor

Issue resolved under intel-retail/core-services#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Intermediate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a microservice to automatically detect when a camera is plugged in (linux nmap)
5 participants