Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve detection and classification pipelines #690

Merged
merged 5 commits into from
Mar 17, 2025

Conversation

antoniomtz
Copy link
Contributor

@antoniomtz antoniomtz commented Mar 14, 2025

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

  • Optimized pipelines for CPU and GPU
  • README updates

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

Run:

DEVICE_ENV=res/all-gpu.env PIPELINE_SCRIPT=yolov5s_effnetb0.sh make run-demo

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

Signed-off-by: Antonio Martinez <[email protected]>
@antoniomtz antoniomtz added the enhancement New feature or request label Mar 14, 2025
@antoniomtz antoniomtz self-assigned this Mar 14, 2025
Signed-off-by: Antonio Martinez <[email protected]>
Signed-off-by: Antonio Martinez <[email protected]>

- [Prerequisites](#prerequisites)
- [QuickStart](#quickstart)
- [Run pipeline on integrated GPU](#run-pipeline-on-integrated-gpu)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Run pipeline on integrated GPU](#run-pipeline-on-integrated-gpu)
- [Run pipeline on integrated GPU (iGPU)](#run-pipeline-on-integrated-gpu)

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add or modify a make target to call the docker-compose-sensors along with the main compose file?

Signed-off-by: Antonio Martinez <[email protected]>
@antoniomtz
Copy link
Contributor Author

antoniomtz commented Mar 14, 2025

Do we need to add or modify a make target to call the docker-compose-sensors along with the main compose file?

@ejlee3 I will create another make target for that compose. The reason is, if we want to run benchmarks, we don't want any extra overhead.

I will create a separate PR

@antoniomtz antoniomtz merged commit 279ac4d into intel-retail:main Mar 17, 2025
8 of 10 checks passed
@antoniomtz antoniomtz deleted the pipeline-optimization branch March 17, 2025 15:03
@antoniomtz antoniomtz changed the title Improve detection and classification pipelines fix: Improve detection and classification pipelines Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants