[Upstream] Rolling Stats rebased against the upstream AC Stats branch #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes printing: - allocSize - allocated memory size - memory usage fraction
guptask
force-pushed
the
upstream_rollstats
branch
from
53d22c1 to
5f67648
Compare
guptask
force-pushed
the
upstream_rollstats
branch
from
5f67648 to
f5145be
Compare
igchor
requested changes
Dec 29, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @guptask)
cachelib/allocator/Cache.h line 89 at r2 (raw file):
// TODO: come up with some reasonable number static constexpr unsigned kMaxTiers = 2;
Is it needed?
guptask
force-pushed
the
upstream_rollstats
branch
from
f5145be to
f82112c
Compare
|
Previously, igchor (Igor Chorążewicz) wrote…
fixed |
igchor
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on @guptask)
byrnedj
pushed a commit
that referenced
this pull request
Jul 23, 2023
Update docker file used in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is