This repository was archived by the owner on Jul 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Settings crash #51
Open
shivasku82
wants to merge
25
commits into
intel:A10_V1
Choose a base branch
from
shivasku82:settings_crash
base: A10_V1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Settings crash #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Image capture in various supported resolutions - Video recording of 1080p,720p and 480p - Multicamera capture and recording - Added clang-format and also coding-style file - Fixed CtsVerifier Camera Intents failure Tracked-On: OAM-84763 Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com>
- Set audio source and profile for video recording with audio - Remove usage of asserts - Change the preview based on resolution selection by user - Changes to address camera and mediarecorder cleanup issues Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com>
Issues addressed: - Recorded video quality not matching with the selected resolution - Preview and recording not working for more than 2 cameras - Multiple permission requests when multiple cameras are connected - Captured image orientation not in line with the orientation - Crash seen on alternate record - Fix for CTSVerifier test case jump - Indentation Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com> Signed-off-by: Muhammad Aksar <muhammad.aksar@intel.com>
-Full Screen view for each camera -Settings screen for each camera -Limited resolution settings to QVGA, VGA, HD, FHD, 4K -Thumbnail for both video & picture capture for Quick Preview -Recording duration countdown while recording video -UI modifications -New Activity to handle Camera Intents -Duration & size info in file details -New Multicamera App Icon Tracked-on: OAM-88628 Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Muhammad Aksar <muhammad.aksar@intel.com>
Add advance features in MultiCamera app
-Video resolution list based on camera capabilities -Audio source set to external mic Tracked-On: OAM-88661 Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Muhammad Aksar <muhammad.aksar@intel.com>
-Videos can be recorded for long duration depending upon available disk space -Camera Preview restricted for 1080p & CIF to 720P & VGA respectively -Preview aspect Ratio (4:3) 0r (16:9) with respect to selected Resolution -Few Code clean-up as well -Add Exif info for Preview Thumbnail Tracked-On: OAM-88922 Signed-off-by: Nikumbh, Mayur NimbaX <mayur.nimbax.nikumbh@intel.com> Signed-off-by: Muhammad Aksar <muhammad.aksar@intel.com>
Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: Kaushal Billore <kaushal.billore@intel.com>
Signed-off-by: Shiva kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: Kaushal Billore <kaushal.billore@intel.com>
Tracked-On : OAM-89663 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: Kaushal Billore <kaushal.billore@intel.com>
Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: Kaushal Billore <kaushal.billore@intel.com>
Tracked-On : OAM-90226 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com>
Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com>
Camera record timer not shown during recording. When front recording is tried, back camera instance is used resulting in crash. Issue fixed by calling showRecordingUI function with correct camera instance. Tracked-On : OAM-91223 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: kbillore <kaushal.billore@intel.com>
RootCause- crash is due to trying to unregister receiver second time in OnPause event Solution- Register receiver only once in application and no need of unregister receiver as it will get unregister automatically on application dies. Tracked-On : OAM-91356 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: kbillore <kaushal.billore@intel.com>
When application opened and user plug\unplug USB camera then application start operation on wrong device id's because when hot plug happends device id's gets realign because of this many stability issues observed on USB hot plug Solution : Whenever USB hot plug detected application will show dialog to close application. Closing and opening application will make application works on right device nodes. Tracked-On : OAM-91443 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: kbillore <kaushal.billore@intel.com>
When video recording is started with USB headset detected, audio device doesn't return USB_DEVICE instead it returns USB_HEADSET. So, preferred audio device is not set resulting in audio not recorded on video recording. Fix the issue by setting preferred device for device type USB_HEADSET. Tracked-On: OAM-91435 Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com>
Multi camera application receive event for every USB device plug and unplug. Whenever USB event is detected application show popup to show application closure. Solution : Dialog will only when USB camera device is plug or unplug. Tracked-On: OAM-91709 Signed-off-by: Shiva Kumara shiva.kumara.rudrappa@intel.com Signed-off-by: kbillore <kaushal.billore@intel.com>
For front camera when we try to pass video_list_1, fetching of video list fails. As a result, video is recorded with resolution 720p. Solution: Fixed the issue by passing video_list instead of video_list_1. Tracked-On : OAM-91963 Signed-off-by: Shiva Kumara shiva.kumara.rudrappa@intel.com Signed-off-by: kbillore <kaushal.billore@intel.com>
click on settings button in single view is working Solution: added required implementation to handle settings button in single view and hide settings button in multiview Tracked-On : OAM-92012 Signed-off-by: Shiva Kumara <shiva.kumara.rudrappa@intel.com> Signed-off-by: kbillore <kaushal.billore@intel.com>
back camera then record. recorded video is falling back to default resolution.when switching the camera, camera close will be called and as part of camera close it will delete the video key entry. Solution: not remove the video key entry as part of camera close. with this only one setting exist for all camera Tracked-On: OAM-94317 Signed-off-by: Shiva Kumara shiva.kumara.rudrappa@intel.com Signed-off-by: kbillore <kaushal.billore@intel.com>
Because of USB xhci event overflow error sometimes camera preview configuration is getting failed. Solution : on receive of stream configuration failure application will retry preview configuration for 5 times before it declare failure Tracked-On: OAM-94318 Signed-off-by: Shiva Kumara shiva.kumara.rudrappa@intel.com Signed-off-by: kbillore <kaushal.billore@intel.com>
when user remove one camera then application detects the hotplug which trigger dialog to user to close application. When user click on dialog to close app which is calling activity finish. In next time application launch app is using cache data for number of camera and it still assume old camera present and try to access there application crash was observed. Solution: instead of activity finish we are killing application process now so next cycle it wont use cache data. Tracked-On: OAM-94319 Signed-off-by: Shiva Kumara shiva.kumara.rudrappa@intel.com Signed-off-by: kbillore <kaushal.billore@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.