Update Ecosystems Mock Test #5073
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
requested changes
May 7, 2025
|
Sorry, I forgot to add one of the files when commiting. I just edited the PR on github directly, let me know if there is any other problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two mock-based unit tests for the update_ecosystems method in osv_source.py to improve coverage without relying on external API calls or real gsutil interactions.
test_update_ecosystems_mocked:
Uses patch to mock out aio_run_command and simulate a basic case where a single ecosystem (ecosystem1) is listed and includes an all.zip file. Verifies that it's correctly recognized and stored.
test_update_ecosystems:
Tests the scenario where multiple ecosystems (python, rust) are listed, but only one (python) includes all.zip. Confirms that rust is excluded from the final result.