refactor out shared code into granulate_utils #923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoniKF
reviewed
Sep 19, 2024
granulate-utils
Outdated
There was a problem hiding this comment.
To make the PRs easier to review, please split it and intel/granulate-utils#261 to the following:
- A
gprofilerPR updating thegranulate-utilssubmodule to the latest master commit. - A
granulate-utilsPR with the 6 moved files added, agprofilerPR with the 6 moved files removed and adapted import statements (no further changes). - A
granulate-utilsPR and agprofilerPR with the rest of the code changes (if there are any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: