Skip to content

Conversation

sebres
Copy link

@sebres sebres commented Oct 15, 2021

Rationales

If one try to build hyperscan in a sub-directory, and boost is linked to include, as it is described in Getting started, one may get an error that boost package is not found:

$ cd /path/to/hyperscan
$ ln -s /path/to/boost ./include/boost
$ mkdir build/Release_x64; cd build/Release_x64
$ cmake -S ../.. -B .
...
CMake Error at cmake/boost.cmake:23 (message):
  Boost 1.57.0 or later not found.  Either install system packages if
  available, extract Boost headers to /path/to/hyperscan/include, or
  set the CMake BOOST_ROOT variable.
...
-- Configuring incomplete, errors occurred!

Note: it seems to be affected only if one uses cmake not in project root directory... for instance like devs doing it often to hold Debug/Release/etc and platforms related (x64/x86) builds in different locations.

This PR proposes a fix for that - it would take a look into include/boost before include.

Toolchain and platform details

$ cmake --version
cmake version 3.20.1

$ grep 'Boost VERSION' ../../include/boost/CMakeLists.txt
project(Boost VERSION 1.78.0 LANGUAGES CXX)

$ bash --version
GNU bash, version 5.1.8(1)-release (x86_64-pc-msys)

$ systeminfo | grep 'OS '
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.19042 N/A Build 19042

…ild in sub-directory (take a look into `include/boost` before `include`);

otherwise `cd build/Release_x64; cmake -S ../.. -B .` may fail, because it cannot find linked boost folder.
@sebres sebres force-pushed the boost-search-path branch from 01b8f18 to 8306d2f Compare October 15, 2021 13:41
GerHobbelt pushed a commit to GerHobbelt/hyperscan that referenced this pull request Aug 31, 2025
…ning (intel#332)

* Clang 17+ is more restrictive on rebind<T> on MacOS/Boost, remove warning

* More clang/boost warnings on MacOS, disable for now
GerHobbelt pushed a commit to GerHobbelt/hyperscan that referenced this pull request Aug 31, 2025
Multiple changes since last release, this will be the last 100% ABI and
API compatible with Hyperscan release.
Next versions will include major refactors and API extensions, it will
be mostly backwards compatible however.
Without particular order, platform support is now:

* Linux (x86, Arm, Power)
* FreeBSD 14 (x86, Arm, Power)
* MacOS 14+ (x86, Arm)

In total more than 200 configurations in the CI are tested for every PR.

Other features:
- Fat Runtime supported for Arm as well (ASIMD/SVE/SVE2).
- Initial implementations for Arm SVE/SVE2 algorithms added, thanks to
Yoan Picchi from Arm.
- SIMDe support added, used as an alternative backend for existing
platforms, but mostly interesting for allowing Vectorscan to build in
new platforms without a supported SIMD engine.
- Various speedups and optimizations.
- Cppcheck and clang-tidy fixes throughout the code, both have been
added to CI for multiple configurations, but only cppcheck triggers a
build failure for now.

Various bugfixes, most important listed:
- Speed up truffle with 256b TBL instructions (intel#290)
- Fix Clang Tidy warnings (intel#295)
- Clang 17+ is more restrictive on rebind<T> on MacOS/Boost, remove
warning (intel#332)
- partial_load_u64 will fail if buf == NULL/c_len == 0 (intel#331)
- Bugfix/fix avx512vbmi regressions (intel#335)
- fix missing hs_version.h header (closes intel#198)
- hs_valid_platform: Fix check for SSE4.2 (intel#310)
- Fixed out of bounds read in AVX512VBMI version of fdr_exec_fat_teddy …
(intel#333)
- Fix noodle SVE2 off by one bug (intel#313)
- Make vectorscan accept \0 starting pattern (intel#312)
- Fix 5.4.11's config step regression (intel#327)
- Fix double shufti's vector end false positive (intel#325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant