[SYCL][Bindless][UR][E2E] Add image memory and handle support queries #17865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces two new SYCL queries for Bindless Images. `get_image_memory_support` returns a vector of supported image backing memory types for a device given an `image_descriptor. `get_image_handle_supported` returns a boolean indicating whether the device supports creation of either a `sampled_image_handle` or `unsampled_image_handle`, given an `image_descriptor` and image backing memory type. Some tests are updated to use these queries to filter out unsupported image properties, e.g. allocating `unorm` channel types on the LevelZero backend.
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
hvdijk
approved these changes
Apr 7, 2025
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
suggested changes
Apr 7, 2025
sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Show resolved
Hide resolved
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
changed the title
przemektmalon
changed the title
przemektmalon
changed the title
npmiller
reviewed
Apr 28, 2025
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
approved these changes
Apr 29, 2025
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Ping @intel/llvm-reviewers-runtime @intel/unified-runtime-reviewers-level-zero |
uditagarwal97
approved these changes
May 1, 2025
DBDuncan
approved these changes
May 1, 2025
igchor
approved these changes
May 1, 2025
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This should be ready to merge. I believe all review groups have approved. Sean's request for changes has been addressed and should not be a blocker for merging this PR. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 1, 2025
I've updated all the known uses when it was introduced in intel#18168 but then intel#17865 added code that didn't use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces two new SYCL queries for Bindless Images.
get_image_memory_supportreturns a vector of supported image backing memory types for a device given an `image_descriptor.is_image_handle_supportedreturns a boolean indicating whether the device supports creation of either asampled_image_handleorunsampled_image_handle, given animage_descriptorand image backing memory type.Some tests are updated to use these queries to filter out unsupported image properties, e.g. allocating
unormchannel types on the LevelZero backend.Additionally some fixes are made to the UR HIP device queries that pertain to supported image properties.
The HIP queries for
UR_DEVICE_INFO_IMAGE<N>D_MAX_<WIDTH/HEIGHT/DEPTH>have been amended to remove redundant calls tohipDeviceGetAttribute(as this was being called twice unnecessarily, with the same query parameter).The HIP queries for
UR_DEVICE_INFO_MAX_IMAGE_LINEAR_<WIDTH/HEIGHT/PITCH>_EXPhave been amended to return plausible values for the HIP backend (instead of returning1for each of these).