Skip to content

[UR] Add dockers to UR workflow #18162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

[UR] Add dockers to UR workflow #18162

merged 2 commits into from
Apr 29, 2025

Conversation

rbanka1
Copy link
Contributor

@rbanka1 rbanka1 commented Apr 23, 2025 •
edited by ayylol
Loading

@rbanka1 rbanka1 requested a review from a team as a code owner April 23, 2025 16:11
@sarnex
Copy link
Contributor

sarnex commented Apr 23, 2025

Is this ready for review?

@lukaszstolarczuk lukaszstolarczuk changed the title [UR] add UR docker [UR] Add dockers to UR workflow Apr 24, 2025
@lukaszstolarczuk
Copy link
Contributor

Is this ready for review?

I think this is the "almost ready" version 😉

lukaszstolarczuk
lukaszstolarczuk requested changes Apr 24, 2025
View reviewed changes
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Apr 24, 2025
Draft
1 task
@rbanka1 rbanka1 force-pushed the dockersUR branch 4 times, most recently from c9935e7 to 9a0506f Compare April 25, 2025 12:57
@rbanka1
added dockers
01cdf11 
Signed-off-by: rbanka1 <[email protected]>
lukaszstolarczuk
lukaszstolarczuk reviewed Apr 25, 2025
View reviewed changes
@rbanka1 rbanka1 force-pushed the dockersUR branch 2 times, most recently from a4e3251 to 2c0fec2 Compare April 25, 2025 15:29
@rbanka1
Copy link
Contributor Author

rbanka1 commented Apr 25, 2025

now it is ready for review

@lukaszstolarczuk
Copy link
Contributor

@intel/dpcpp-devops-reviewers and maybe @intel/unified-runtime-reviewers pls take a look

lukaszstolarczuk
lukaszstolarczuk approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside minor issue, lgtm

sarnex
sarnex approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sane to me, thanks!

@rbanka1
added dockers fix
8705ba4 
Signed-off-by: rbanka1 <[email protected]>
@lukaszstolarczuk
Copy link
Contributor

@intel/llvm-gatekeepers - I believe this is ready for merge.

@kbenzie kbenzie merged commit b96fdbd into intel:sycl Apr 29, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBrunton RossBrunton RossBrunton approved these changes

@sarnex sarnex sarnex approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbanka1 @sarnex @lukaszstolarczuk @RossBrunton @kbenzie