-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Reject unsuitable old ocloc from Kernel Compile by passing device IPVersions when loading #18170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Reject unsuitable old ocloc from Kernel Compile by passing device IPVersions when loading #18170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to:
- Add a fallback on Windows that checks for an ocloc DLL in a fixed location, if one isn't found using standard DLL search orders.
- Performs an ocloc query when loading the ocloc DLL as a test to determine that the ocloc library is "good".
Both of these changes are improvements over the existing code, hence my review approval, but I think we ought to reconsider how we handle this in the future. For example:
- Can we handle the case where the user installs into a non-standard directory and hence the ocloc DLL isn't found at the fixed location?
- When there are multiple devices in the system, are there cases where we may need multiple ocloc libraries? Should the ocloc library handle be tied to the SYCL context (or perhaps the SYCL device, or the SYCL platform) rather than stored in a single static global variable?
- Can we add some encapsulation so this code is easier to understand and maintain in the future?
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
…different PR Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title is still wrong.
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
For Kernel Compiler Open CL C support the
device.ext_can_compile
now passes the device down so we can make sure OCLOC supports commands with the -dev IPVersionStr .