[SYCL][Graph][OpenCL] Map copy/fill to SVM #18177
Merged
+96
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/graph_ocl_svm_fill
branch
from
7617e70 to
b995e2f
Compare
EwanC
force-pushed
the
ewan/graph_ocl_svm_fill
branch
from
b995e2f to
5c9635f
Compare
EwanC
force-pushed
the
ewan/graph_ocl_svm_fill
branch
from
5c9635f to
e7c3ed7
Compare
Bensuo
approved these changes
Apr 25, 2025
steffenlarsen
pushed a commit
that referenced
this pull request
Apr 25, 2025
There are currently limitations on what commands can be added to a SYCL-Graph that we document in the [design doc](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/CommandGraph.md#opencl) and mark as unsupported in Graph E2E tests. However, we never marked the equivalent UR command-buffer commands as unsupported in the CTS, so they will currently fail when testing against an OpenCL backend with support for the extension. Address this by marking CTS tests which use these commands as unsupported. Note that this will conflict with #18177 in that some CTS tests can be re-enabled, but I can resolve that based on whatever merges first.
EwanC
force-pushed
the
ewan/graph_ocl_svm_fill
branch
from
e7c3ed7 to
ad932f0
Compare
There is currently no cl_khr_command_buffer or cl_intel_unified_shared_memory entry-point for appending USM copy or fill commands to a command-buffer. This prevents these commands from being added to a graph for the OpenCL backend. The long term solution to this is the OpenCL USVM extension which will align USM and SVM, allowing the existing SVM entry-points to be used. To prepare for this, map the UR entry-points to the cl_khr_command_buffer SVM copy/fill commands. This will work on OpenCL implementations that share an implementation for USM and SVM. Signed-off-by: Ewan Crawford <[email protected]>
EwanC
force-pushed
the
ewan/graph_ocl_svm_fill
branch
from
ad932f0 to
5f06c13
Compare
cperkinsintel
approved these changes
Apr 25, 2025
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no cl_khr_command_buffer or cl_intel_unified_shared_memory entry-point for appending USM copy or fill commands to a command-buffer. This prevents these commands from being added to a graph for the OpenCL backend.
The long term solution to this is the OpenCL USVM extension which will align USM and SVM, allowing the existing SVM entry-points to be used. To prepare for this, map the UR entry-points to the cl_khr_command_buffer SVM copy/fill commands.
This will work on OpenCL implementations that share an implementation for USM and SVM.